Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove libs that panic #2791

Merged
merged 1 commit into from
May 9, 2024
Merged

chore: remove libs that panic #2791

merged 1 commit into from
May 9, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 9, 2024 •
edited
Loading

Summary

This PR fixes the benchmarking job. I removed the CSS files that were causing parsing errors, and changes the code to print the diagnostics if there are any.

Test Plan

I think this PR should pass

@github-actions github-actions bot added the A-Tooling Area: internal tools label May 9, 2024
@ematipico ematipico requested review from a team May 9, 2024 13:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 9, 2024

CodSpeed Performance Report

Merging #2791 will not alter performance

Comparing fix/css-benchmark (bbb84f5) with main (83a5c01)

Summary

✅ 84 untouched benchmarks

🆕 13 new benchmarks

Benchmarks breakdown

Benchmark main fix/css-benchmark Change
🆕 css_analyzer[bootstrap.css] N/A 1.2 s N/A
🆕 css_analyzer[bulma.css] N/A 450.6 ms N/A
🆕 css_analyzer[foundation.css] N/A 267.8 ms N/A
🆕 css_analyzer[pure.css] N/A 30 ms N/A
🆕 css_analyzer[tachyons.css] N/A 201.5 ms N/A
🆕 css_formatter[bootstrap.css] N/A 581.9 ms N/A
🆕 css_formatter[bulma.css] N/A 596.5 ms N/A
🆕 css_formatter[foundation.css] N/A 395 ms N/A
🆕 css_formatter[full.css] N/A 5.9 s N/A
🆕 css_formatter[materialize.css] N/A 435.1 ms N/A
🆕 css_formatter[pure.css] N/A 50.6 ms N/A
🆕 css_formatter[semantic.css] N/A 1.6 s N/A
🆕 css_formatter[tachyons.css] N/A 213.4 ms N/A

@ematipico ematipico merged commit ee5b9ee into main May 9, 2024
17 checks passed
@ematipico ematipico deleted the fix/css-benchmark branch May 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@togami2864 togami2864 togami2864 approved these changes

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Tooling Area: internal tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @Conaclos @togami2864